From: Kalle Vahlman <kalle.vahlman@movial.com>
Date: Thu, 30 Apr 2009 07:45:31 +0000 (+0300)
Subject: [xpcom] Fix ref leak with DataCarrier values
X-Git-Tag: 1.0~11
X-Git-Url: https://sandbox.movial.com/gitweb/?p=browser-dbus-bridge.git;a=commitdiff_plain;h=3254cdf7f2a3c0b6bcafe4ff1aa7f870e75ef7d5

[xpcom] Fix ref leak with DataCarrier values
---

diff --git a/xpcom-dbusservice/DBusMarshaling.cpp b/xpcom-dbusservice/DBusMarshaling.cpp
index 0512263..02f332d 100644
--- a/xpcom-dbusservice/DBusMarshaling.cpp
+++ b/xpcom-dbusservice/DBusMarshaling.cpp
@@ -418,9 +418,10 @@ addVariantToIter(JSContext* cx, nsIVariant *aVariant, DBusMessageIter *aIter, DB
 
         nsCOMPtr<DBusDataCarrier> myCarrier = do_QueryInterface(is);
         if (myCarrier) {
-            nsCOMPtr<nsIVariant> myValue;
-            myCarrier->GetValue(getter_AddRefs(myValue));
+            nsIVariant *myValue;
+            myCarrier->GetValue(&myValue);
             addVariantToIter(cx, myValue, aIter, aSigIter);
+            NS_IF_RELEASE(myValue);
             return;
         }
     }